[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ef65adb6f9d: [Sema][CodeComplete][ObjC] Dont include arrow/dot fixits (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269271. dgoldman added a comment. - Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269269. dgoldman marked an inline comment as done. dgoldman added a comment. - Minor comment fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5199 + // Objective-C property reference. Bail if we're performing fix-it code + // completion since we don't handle forwarding the fix-it for Objective-C + // objects. Since

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

sammccall accepted this revision. sammccall added a comment. LG, thanks! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5199 + // Objective-C property reference. Bail if we're performing fix-it code + // completion since we don't handle forwarding the fix-it for

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5153 - auto DoCompletion = [&](Expr *Base, bool IsArrow, + auto DoCompletion = [&](Expr *Base, bool IsArrow, bool IncludeObjC, Optional AccessOpFixIt) -> bool {

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269192. dgoldman marked 4 inline comments as done. dgoldman added a comment. Remove stale comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 269189. dgoldman added a comment. Check AccessOpFixIt.hasValue() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:5153 - auto DoCompletion = [&](Expr *Base, bool IsArrow, + auto DoCompletion = [&](Expr *Base, bool IsArrow,

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

yvvan added a comment. I'm not a big objC expert here. The idea looks fine to me and won't affect my workflow. So let's take this patch if nobody comments against it here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 268818. dgoldman added a comment. - Fix broken diff base (due to lint fixes maybe?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/test/CodeCompletion/objc-member-access.m Index:

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

dgoldman created this revision. dgoldman added reviewers: sammccall, yvvan. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Exempt ObjC from arrow/dot fixits since this has