This revision was automatically updated to reflect the committed changes.
Closed by commit rG3e59dfc30124: [llvm][SveEmitter] Emit the bfloat version of
`svld1ro`. (authored by fpetrogalli).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81304/new/
h
stuij accepted this revision.
stuij added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81304/new/
https://reviews.llvm.org/D81304
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
stuij added inline comments.
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64
-D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple
aarch64-none-linux-gnu -target-feature +sve -targe
sdesmalen added inline comments.
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64
-D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple
aarch64-none-linux-gnu -target-feature +sve -t
fpetrogalli updated this revision to Diff 271178.
fpetrogalli marked 3 inline comments as done.
fpetrogalli added a comment.
Fix formatting issues, remove an unnecessary empty line.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81304/new/
https://r
fpetrogalli added inline comments.
Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:44
#define SVE_VECTOR_TYPE(Name, MangledName, Id, SingletonId, NumEls, ElBits,
\
-IsSigned, IsFP)
\
+
sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:44
#define SVE_VECTOR_TYPE(Name, MangledName, Id, SingletonId, NumEls, ElBits,
\
-
sdesmalen added inline comments.
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64
-D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple
aarch64-none-linux-gnu -target-feature +sve -t
fpetrogalli added a comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81304/new/
https://reviews.llvm.org/D81304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
fpetrogalli updated this revision to Diff 270911.
fpetrogalli marked 4 inline comments as done.
fpetrogalli added a comment.
Thank you for the review @sdesmalen.
Francesco
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81304/new/
https://reviews.ll
stuij added inline comments.
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ld1ro-bfloat.c:1
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE_MATMUL_FP64
-D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -D__ARM_FEATURE_SVE -triple
aarch64-none-linux-gnu -target-feature +sve -targe
sdesmalen added a comment.
Thanks @fpetrogalli, the changes look good to me. Just added some minor
comments.
Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:63
-SVE_VECTOR_TYPE("__SVFloat16_t", SveFloat16, SveFloat16Ty, 8, 16, true, true)
-SVE_VECTOR_TYPE("__SV
fpetrogalli created this revision.
fpetrogalli added reviewers: sdesmalen, efriedma, stuij, ctetreau.
Herald added subscribers: cfe-commits, tschuett.
Herald added a reviewer: shafik.
Herald added a reviewer: rengolin.
Herald added a project: clang.
The new SVE builtin type __SVBFloat16_t` is used
13 matches
Mail list logo