MaskRay added a comment.
Herald added a project: All.
The convention is to use `err_drv_unsupported_option_argument` instead of
adding a new diagnostic kind.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81404/new/
https://reviews.llvm.org/D81404
kristof.beyls marked 2 inline comments as done.
kristof.beyls added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:229
+ Scope.split(Opts, ",");
+ for (int I = 0, E = Opts.size(); I != E; ++I) {
+StringRef Opt = Opts[I].trim();
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc113b59ef525: [AArch64] Add clang command line support for
-mharden-sls= (authored by kristof.beyls).
Changed prior to commit:
https://reviews.llvm.org/D81404?vs=269247=271925#toc
Repository:
rG
ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.
LGTM, inline comment could be done as a follow-up patch given that this is
time-sensitive (recently published security vulnerability).
Comment at:
kristof.beyls created this revision.
kristof.beyls added a reviewer: ostannard.
Herald added subscribers: cfe-commits, danielkiss.
Herald added a project: clang.
The accepted options to -mharden-sls= are:
- all: enable all mitigations against Straight Line Speculation that are
implemented.
-
