This revision was automatically updated to reflect the committed changes.
Closed by commit rG1ec469cf4c20: [OPENMP50]Codegen for scan directives in
parallel for regions. (authored by ABataev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81478/new/
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
LGTM and cleaner than my sketch, thanks a lot :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81478/new/
https://reviews.llvm.org/D81478
ABataev updated this revision to Diff 271437.
ABataev added a comment.
Rebase + avoid copy paste.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81478/new/
https://reviews.llvm.org/D81478
Files:
clang/lib/CodeGen/CGStmtOpenMP.cpp
clang/test/Ope
ABataev marked an inline comment as done.
ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627
+ emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen);
+} else {
+ OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627
+ emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen);
+} else {
+ OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S.hasCancel());
ABataev
ABataev marked an inline comment as done.
ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627
+ emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen);
+} else {
+ OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627
+ emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen);
+} else {
+ OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S.hasCancel());
ABataev
ABataev marked an inline comment as done.
ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627
+ emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen);
+} else {
+ OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S
jdoerfert added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3627
+ emitScanBasedDirective(CGF, S, NumIteratorsGen, FirstGen, SecondGen);
+} else {
+ OMPCancelStackRAII CancelRegion(CGF, OMPD_parallel_for, S.hasCancel());
This loo
ABataev updated this revision to Diff 271115.
ABataev added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81478/new/
https://reviews.llvm.org/D81478
Files:
clang/lib/CodeGen/CGStmtOpenMP.cpp
clang/test/OpenMP/parallel_for_sca
ABataev created this revision.
ABataev added a reviewer: jdoerfert.
Herald added subscribers: sstefan1, guansong, yaxunl.
Herald added a project: clang.
Added codegen for scan directives in parallel for regions.
Emits the code for the directive with inscan reductions.
Original code:
#pragma om
11 matches
Mail list logo