[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

jaafar added a comment. Thanks for the detailed analysis! I have filed https://github.com/boostorg/spirit/issues/612 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81530/new/ https://reviews.llvm.org/D81530 __

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

sammccall added a comment. In D81530#2085725 , @jaafar wrote: > I can confirm that this commit works equally well for the UTF-8 assertion > failure. Thank you! > > Is there some way to easily modify the source to produce a diagnostic > pointing to the is

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

jaafar added a comment. I can confirm that this commit works equally well for the UTF-8 assertion failure. Thank you! Is there some way to easily modify the source to produce a diagnostic pointing to the issue's source location? I would like to file an appropriate bug in Boost. Repository:

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2c8f6e16d25: [clangd] Log rather than assert on bad UTF-8. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81530/new/ https://review

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! (i bet you rushed it already for the cherry-pick, but just wanted to remind again that we should :D) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall added a subscriber: jaafar. sammccall added a comment. @jaafar would you be able to verify t

[PATCH] D81530: [clangd] Log rather than assert on bad UTF-8.

sammccall added a subscriber: jaafar. sammccall added a comment. @jaafar would you be able to verify this is equivalent to D74731 for your purposes? If so I'd like to cherrypick this into tho 10.x branch after landing. Repository: rG LLVM Github Monorepo CHA