[PATCH] D81608: Fix incorrect call to ExprResult::get()

2020-06-11 Thread Alexander Richardson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG385e5f7e147f: Fix incorrect call to ExprResult::get() (authored by arichardson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81608/new/

[PATCH] D81608: Fix incorrect call to ExprResult::get()

2020-06-11 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Great spot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81608/new/ https://reviews.llvm.org/D81608

[PATCH] D81608: Fix incorrect call to ExprResult::get()

2020-06-10 Thread Alexander Richardson via Phabricator via cfe-commits
arichardson created this revision. arichardson added reviewers: Anastasia, pekka.jaaskelainen. Herald added a project: clang. Herald added a subscriber: cfe-commits. Res is already a ExprResult, so if we call .get() we convert an ExprError() result into an unset result. I discovered this in our