[PATCH] D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible()

2020-06-16 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D81732#2094735 , @mboehme wrote: > In D81732#2093260 , @dblaikie wrote: > > > Test case(s)? > > > Is there anything specific you have in mind? > > This change should be

[PATCH] D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible()

2020-06-15 Thread Martin Böhme via Phabricator via cfe-commits
mboehme added a comment. In D81732#2093260 , @dblaikie wrote: > Test case(s)? Is there anything specific you have in mind? This change should be behavior-preserving in the case where -fmodules-local-submodule-visibility isn't set, as evidenced by the

[PATCH] D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible()

2020-06-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Test case(s)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81732/new/ https://reviews.llvm.org/D81732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible()

2020-06-12 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. mboehme added a reviewer: rsmith. mboehme added a project: clang. Herald added a subscriber: cfe-commits. For context, see https://bugs.llvm.org/show_bug.cgi?id=46248 This handles only the easy cases in Sema/SemaDeclObjC.cpp. The cases in AST/DeclObjC.{h,cpp} will