This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool
false-positive with binary conditional… (authored by
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f71cf6d77c5: [SemaObjC] Fix a -Wobjc-signed-char-bool
false-positive with binary conditional… (authored by
ahatanak added a comment.
This looks good to me.
Comment at: clang/lib/Sema/SemaChecking.cpp:11825
+ Expr *TrueExpr = E->getTrueExpr();
+ if (isa(E))
Can you use `BinaryConditionalOperator::getCommon` here?
CHANGES SINCE LAST ACTION
erik.pilkington added a reviewer: ahatanak.
erik.pilkington added a comment.
Ping!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81751/new/
https://reviews.llvm.org/D81751
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
erik.pilkington created this revision.
erik.pilkington added a reviewer: rjmccall.
Herald added subscribers: ributzka, dexonsmith, jkorous.
We were previously bypassing the conditional expression special case for binary
conditional expressions. Also, dig through the OpaqueValueExpr on the left
