[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3fd9dc9734c: [clang] Enable -mms-bitfields by default for mingw targets (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81795/new/ ht

[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81795/new/ https://reviews.llvm.org/D81795 _

[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

mstorsjo added a comment. In D81795#2092878 , @rjmccall wrote: > Seems reasonable; GCC is the "system compiler" for this platform. Does > `isWindowsGNUEnvironment` exactly track the condition that GCC uses? It's > just MinGW, not Cygwin? Yes: https

[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

rjmccall added a comment. Seems reasonable; GCC is the "system compiler" for this platform. Does `isWindowsGNUEnvironment` exactly track the condition that GCC uses? It's just MinGW, not Cygwin? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D817

[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

mstorsjo created this revision. mstorsjo added reviewers: rjmccall, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches GCC, which enabled -mms-bitfields by default for mingw targets in 4.7 [1]. [1] https://www.gnu.org/software/gcc/gcc-4.7/changes.html Repo