[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rGc830d517b4e4: [HIP] Enable -amdgpu-internalize-symbols (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:64-65 +"-shared", +"-mllvm", +"-amdgpu-internalize-symbols", +

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:64-65 +"-shared", +"-mllvm", +"-amdgpu-internalize-symbols", +"-o", We should probably

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81959/new/ https://reviews.llvm.org/D81959 ___ cfe-commits mailing list

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

yaxunl added a comment. In D81959#2096616 , @arsenm wrote: > Isn't the internalization implied by LTO? I thought part of the appeal of LTO > is killing this off How does LTO know that the kernels need to be kept? CHANGES SINCE LAST ACTION

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

arsenm added a comment. Isn't the internalization implied by LTO? I thought part of the appeal of LTO is killing this off CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81959/new/ https://reviews.llvm.org/D81959 ___ cfe-commits mailing

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

yaxunl created this revision. yaxunl added reviewers: arsenm, rampitec, tra, ashi1. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. Enable -amdgpu-internalize-symbols to eliminate unused functions and global variables for whole program to speed up compilation and improve