[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f298c8206b: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I understand the clangd stuff better now, and scanning through the other changes they seem to be the same pattern. LGTM Comment at:

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:105 + +clang_target_link_libraries(clangDaemon + PRIVATE sammccall wrote: > This has split our link dependencies in two, and I'm not

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

sammccall added a comment. I'm afraid I don't really understand how this fix works, so my questions might be silly. Thanks for fixing things! Comment at: clang-tools-extra/clangd/CMakeLists.txt:105 + +clang_target_link_libraries(clangDaemon + PRIVATE This

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

mgorny added a comment. Ok, I don't think this failure is due to my changes but I've proposed a solution as D82001 anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81967/new/ https://reviews.llvm.org/D81967

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

mgorny added a comment. Herald added a subscriber: wuzish. For the record, this seems to trigger some command-line option parser problem: TEST 'Clang Tools :: clang-tidy/infrastructure/invalid-command-line.cpp' FAILED

[PATCH] D81967: [clang-tools-extra] Prevent linking to duplicate .a libs and dylib

mgorny created this revision. mgorny added reviewers: alexfh, hokein, sammccall, ilya-biryukov, kadircet, ioeric, bkramer, aaron.ballman, klimek, juliehockett. Herald added subscribers: sstefan1, phosek, usaxena95, lebedev.ri, arphaman, jkorous, kbarton, nemanjai. Herald added a reviewer: