[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

This revision was automatically updated to reflect the committed changes. Closed by commit rG0628705efaf7: [clangd][NFC] Rename FSProvider and getFileSystem (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

sammccall accepted this revision. sammccall added a comment. Thanks for this, and sympathies for inevitable merge conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/ https://reviews.llvm.org/D81998

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestFS.h:36 public: - // Prevent name hiding caused by the overload below. - using FileSystemProvider::getFileSystem; - IntrusiveRefCntPtr getFileSystem() const { return buildTestFS(Files,

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

kadircet updated this revision to Diff 271979. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/ https://reviews.llvm.org/D81998 Files:

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/TestFS.h:34 // A VFS provider that returns TestFSes containing a provided set of files. -class MockFSProvider : public FileSystemProvider { +class MockFSProvider : public ThreadsafeFS { public:

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/support/ThreadsafeFS.h:31 + virtual ~ThreadsafeFS() = default; + /// Obtain a vfs::FileSystem with an arbitrary initial

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

kadircet updated this revision to Diff 271386. kadircet marked an inline comment as done. kadircet added a comment. Herald added subscribers: javed.absar, mgorny. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

kadircet marked 6 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:722 /* Override */ OverrideClangTidyOptions, -FSProvider.getFileSystem(/*CWD=*/llvm::None)); +

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/FSProvider.h:1 //===--- FSProvider.h - VFS provider for ClangdServer *- C++-*-===// // we should rename this file as well :-( Comment at:

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

kadircet updated this revision to Diff 271357. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/ https://reviews.llvm.org/D81998 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

kadircet updated this revision to Diff 271330. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81998/new/ https://reviews.llvm.org/D81998 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D81998: [clangd][NFC] Rename FSProvider and getFileSystem

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Clangd uses FSProvider to get threadsafe views into file systems. This patch changes naming to make