[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

njames93 added a comment. I'm of the idea that rather than having `ClangdTidyOptionsProvider` inherit form `tidy::ClangTidyOptionsProvider`, just have it as its own class. We don't need the interface offered by clang tidy here. It would solve the `must be threadsafe` comment issue as well as

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

njames93 added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:495-498 +bool HasChecks = false; +for (const auto : Sources) + HasChecks |= Source.first.Checks.hasValue(); +if (!HasChecks) `if (llvm::none_of(Sources,

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.h:46 -/// to allow reading tidy configs from the VFS used for parsing. -using ClangTidyOptionsBuilder = std::function; Hmm, I like the idea of avoiding a custom type and just

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

kadircet updated this revision to Diff 271358. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82002/new/ https://reviews.llvm.org/D82002 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

kadircet updated this revision to Diff 271342. kadircet added a comment. - Accept an inner opt provider instead to enable wrapping other types of providers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82002/new/ https://reviews.llvm.org/D82002

[PATCH] D82002: [clangd] Drop FS usage in ClangTidyOpts

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Depends on D81998 Repository: rG LLVM Github Monorepo