[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-25 Thread Kevin P. Neal via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG15edd7aaa714: [FPEnv] PowerPC-specific builtin constrained FP enablement (authored by ajwock, committed by kpn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-22 Thread Qing Shan Zhang via Phabricator via cfe-commits
steven.zhang accepted this revision. steven.zhang added a comment. This revision is now accepted and ready to land. LGTM now and thank you for doing this. Please hold on for 2-3 days in case others have comments. And thank you for pointing a potential issue of the folding of fneg + fma. We will

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-21 Thread Andrew J Wock via Phabricator via cfe-commits
ajwock updated this revision to Diff 272330. ajwock added a comment. It seems one of the issues that my tests revealed was already remedied in very recent changes, causing my test to fail. I changed the test to reflect that while also taking steven's recommendations. CHANGES SINCE LAST ACTION

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-21 Thread Qing Shan Zhang via Phabricator via cfe-commits
steven.zhang added a comment. LGTM overall with some minor comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14238 BuiltinID == PPC::BI__builtin_vsx_xvrspi) - ID = Intrinsic::round; + ID = Builder.getIsFPConstrained() ?

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-19 Thread Andrew J Wock via Phabricator via cfe-commits
ajwock updated this revision to Diff 272186. ajwock added a comment. Took steven.zhang's suggestion, added REQUIRES line to diff. Hopefully addressed harbormaster concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82020/new/ https://reviews.llvm.org/D82020 Files:

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-17 Thread Qing Shan Zhang via Phabricator via cfe-commits
steven.zhang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14069 + BuiltinID == PPC::BI__builtin_vsx_xvrspim) +ID = Intrinsic::floor; + else if (BuiltinID == PPC::BI__builtin_vsx_xvrdpi || Can we do it like this to

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-17 Thread Andrew J Wock via Phabricator via cfe-commits
ajwock created this revision. ajwock added reviewers: kpn, cameron.mcinally, spatel, hfinkel, nemanjai, kbarton. Herald added subscribers: cfe-commits, steven.zhang, shchenz. Herald added a project: clang. ajwock added a reviewer: steven.zhang. This change enables PowerPC compiler builtins to