This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rGf0084c3bcbc2: [AST][RecoveryExpr] Fix a crash: don't
attach error-type base specifiers. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:2430
+ if (BaseType->containsErrors()) {
+// FIXME: should we emit a diagnostic here? We already emit a diagnostic
+
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang/test/SemaCXX/invalid-template-base-specifier.cpp:6
+template
+struct Crash : decltype(Foo(T())) { // expected-error {{no matching function
for call to 'Foo'}}
+ Crash(){};
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added a project: clang.
hokein edited the summary of this revision.
otherwise we'll run into code path which expects a good base specifiers,
and lead to crashes.
The crash only occurs in template instantiations (in non-templ
