[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9a539c01084: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals (authored by aardappel). Changed prior to commit: https://reviews.llvm.org/D82130?vs=273539=273548#toc

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel updated this revision to Diff 273539. aardappel added a comment. types & variables in InputChunks.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82130/new/ https://reviews.llvm.org/D82130 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp lld/wasm/Config.h

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

dschuff accepted this revision. dschuff added a comment. Compiler changes LGTM Comment at: llvm/test/CodeGen/WebAssembly/stack-alignment.ll:1 -; RUN: llc < %s -asm-verbose=false -disable-wasm-fallthrough-return-opt -wasm-keep-registers | FileCheck %s - -target datalayout =

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

sbc100 accepted this revision. sbc100 added a comment. Linker changes still lgtm % comments Comment at: lld/wasm/InputChunks.cpp:338 + auto WASM_OPCODE_PTR_CONST = + config->is64 ? WASM_OPCODE_I64_CONST : WASM_OPCODE_I32_CONST; sbc100 wrote: > Just use

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel updated this revision to Diff 273503. aardappel added a comment. - Fixed ISEL for FrameIndex - Fixed 64-bit conditions in branches (thanks @aheejin!) - Made the FrameIndex generation code in WebAssemblyRegisterInfo work. - Made userstack.ll and stack-alignment.ll pass in wasm64. - Code

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel added a comment. @dschuff still working on it, it uncovered some issues (as it should :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82130/new/ https://reviews.llvm.org/D82130 ___ cfe-commits mailing list

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

dschuff added a comment. So the code LGTM, were you going to add to usertest.ll in this CL? Comment at: llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp:84 WasmSym->setGlobalType(wasm::WasmGlobalType{ -uint8_t(Subtarget.hasAddr64() ? wasm::WASM_TYPE_I64 -

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Great! Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:68 + else +CmdArgs.push_back("-m wasm32"); + All the other drivers seem to do

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel marked 2 inline comments as done. aardappel added a comment. I'll likely fork `userstack.ll` since the majority of lines need changes. Comment at: lld/wasm/Driver.cpp:385 +StringRef s = arg->getValue(); +if (s == "wasm32") + config->is64 = false;

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

dschuff added a comment. Yeah I think a 64-bit version of userstack.ll makes sense. (a fork or a second set of CHECKs, whatever you think would be cleaner). There's also `stack-alignment.ll` which covers dynamic stack adjustment. Comment at: lld/wasm/Driver.cpp:385 +

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel created this revision. aardappel added reviewers: sbc100, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin, hiraditya, jgravelle-google. Herald added projects: clang, LLVM. aardappel updated this revision to Diff 271859. aardappel added a comment. This is

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel updated this revision to Diff 271859. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82130/new/ https://reviews.llvm.org/D82130 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp lld/wasm/Config.h lld/wasm/Driver.cpp lld/wasm/InputChunks.cpp lld/wasm/Options.td

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel added a comment. This is a first iteration, probably needs more tests :) I was thinking of forking `userstack.ll` since it has most `__stack_pointer` tests, but I am not sure if it's that useful. Needs a test that uses the new wasm-ld flag. Opinions welcome. CHANGES SINCE LAST