c-rhodes added inline comments.
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-perm-select.ll:809
+define @rev_bf16( %a) {
+; CHECK-LABEL: rev_bf16
sdesmalen wrote:
> Does this test not need the `+bf16` attribute to work? (which implies the
> patterns a
c-rhodes marked an inline comment as done.
c-rhodes added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1115
+let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in {
+def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone,
"aarch64_sve_rev">;
---
sdesmalen added inline comments.
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-perm-select.ll:809
+define @rev_bf16( %a) {
+; CHECK-LABEL: rev_bf16
Does this test not need the `+bf16` attribute to work? (which implies the
patterns are missing the right
This revision was automatically updated to reflect the committed changes.
Closed by commit rG26502ad60922: [AArch64][SVE] Add bfloat16 support to perm
and select intrinsics (authored by c-rhodes).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82182/n
c-rhodes added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1115
+let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in {
+def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone,
"aarch64_sve_rev">;
fpetrogalli wrote:
> c-rhodes
fpetrogalli added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1115
+let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in {
+def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone,
"aarch64_sve_rev">;
c-rhodes wrote:
> c-rhodes
c-rhodes updated this revision to Diff 272745.
c-rhodes added a comment.
Changes:
- Moved bfloat tests to separate files.
- Added checks to test intrinsics are guarded by feature flag, this is by
omitting the feature macro `__ARM_FEATURE_SVE_BF16` for now but will eventually
be updated to omit
c-rhodes added inline comments.
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_sel.c:2
// REQUIRES: aarch64-registered-target
-// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu
-target-feature +sve -fallow-half-arguments-and-returns -S -O1 -W
sdesmalen added inline comments.
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_sel.c:2
// REQUIRES: aarch64-registered-target
-// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu
-target-feature +sve -fallow-half-arguments-and-returns -S -O1 -
c-rhodes added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1115
+let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in {
+def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone,
"aarch64_sve_rev">;
c-rhodes wrote:
> fpetrogalli
c-rhodes added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1115
+let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in {
+def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone,
"aarch64_sve_rev">;
fpetrogalli wrote:
> nit: cou
david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82182/new/
https://reviews.llvm.org/D82182
fpetrogalli added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1115
+let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in {
+def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone,
"aarch64_sve_rev">;
nit: could create a multic
c-rhodes created this revision.
c-rhodes added reviewers: sdesmalen, efriedma, stuij, david-arm, fpetrogalli,
kmclaughlin.
Herald added subscribers: danielkiss, psnobl, rkruppe, hiraditya,
kristof.beyls, tschuett.
Herald added projects: clang, LLVM.
Added for following intrinsics:
- zip1, zip2,
14 matches
Mail list logo
