sdesmalen added inline comments.
Comment at:
llvm/test/CodeGen/AArch64/sve-intrinsics-ld1-addressing-mode-reg-imm.ll:217
+ %base_scalar = bitcast * %base to bfloat*
+ %load = call @llvm.aarch64.sve.ld1.nxv8bf16( %pg, bfloat* %base_scalar)
+ ret %load
Sorry
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3d6cab271c7c: [AArch64][SVE] Add bfloat16 support to load
intrinsics (authored by kmclaughlin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82298/new/
htt
sdesmalen accepted this revision.
sdesmalen added a comment.
LGTM
Comment at: clang/include/clang/Basic/arm_sve.td:275
+let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in {
+ def SVLD1_BF : MInst<"svld1[_{2}]", "dPc", "b", [IsLoad],
MemEltTyDefault, "aarch64_sve_
fpetrogalli accepted this revision.
fpetrogalli added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82298/new/
https://reviews.llvm.org/D82298
___
cfe-commits mailing
kmclaughlin updated this revision to Diff 272759.
kmclaughlin added a comment.
- Moved bfloat tests into separate files
- Added checks to the bfloat test files which test the warnings given when
ARM_FEATURE_SVE_BF16 is omitted in the RUN line
CHANGES SINCE LAST ACTION
https://reviews.llvm.org
david-arm added inline comments.
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ldnf1.c:2-4
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC
-D__ARM_FEATURE_SVE_BF16 -triple aarch64-none-linux-gnu -target-feature +sve
-target-featur
sdesmalen added inline comments.
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ldnf1.c:2-4
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC
-D__ARM_FEATURE_SVE_BF16 -triple aarch64-none-linux-gnu -target-feature +sve
-target-featur
fpetrogalli requested changes to this revision.
fpetrogalli added inline comments.
This revision now requires changes to proceed.
Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ldnf1.c:2-4
+// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_BF16_SCALAR_ARITHME
kmclaughlin created this revision.
kmclaughlin added reviewers: sdesmalen, c-rhodes, efriedma, stuij, fpetrogalli,
david-arm.
Herald added subscribers: llvm-commits, cfe-commits, danielkiss, psnobl,
rkruppe, hiraditya, kristof.beyls, tschuett.
Herald added projects: clang, LLVM.
Bfloat16 support
