[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-25 Thread Alexey Bataev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG32ea3397bec8: [OPENMP]Dynamic globalization for parallel target regions. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324/new/ htt

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the explanation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324/new/ https://reviews.llvm.org/D82324

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-24 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev marked an inline comment as done. ABataev added a comment. In D82324#2112388 , @jdoerfert wrote: > Let me rephrase. Does the user needs to request the fast path or the user > needs to request the slow but correct path? Only the former is acceptabl

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. Let me rephrase. Does the user needs to request the fast path or the user needs to request the slow but correct path? Only the former is acceptable IMHO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324/new/ https://r

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-24 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added a comment. In D82324#2111953 , @jdoerfert wrote: > I do not understand why we need the flag. As far as I can tell, it has to be > on to support the standard described behavior, right? Why should we (allow > to) turn it off? It might use "

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-24 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. I do not understand why we need the flag. As far as I can tell, it has to be on to support the standard described behavior, right? Why should we (allow to) turn it off? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

2020-06-22 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl, jholewinski. Herald added a project: clang. Added support for dynamic memory allocation for globalized variables in case if execution of target regions in parallel is required.