[PATCH] D82352: [clangd] Make background index thread count calculation clearer

2020-06-24 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3c5745cb1f3c: [clangd] Make background index thread count calculation clearer (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82352/ne

[PATCH] D82352: [clangd] Make background index thread count calculation clearer

2020-06-24 Thread Sam McCall via Phabricator via cfe-commits
sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Background.h:140 + // In production an explicit value is passed. + size_t ThreadPoolSize = 4, std::function OnProgress = nullptr);

[PATCH] D82352: [clangd] Make background index thread count calculation clearer

2020-06-23 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks LGTM! Comment at: clang-tools-extra/clangd/index/Background.h:140 + // In production an explicit value is passed. + size_t ThreadPoolSize = 4, std

[PATCH] D82352: [clangd] Make background index thread count calculation clearer

2020-06-23 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. LGTM. Thanks for reverting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82352/new/ https://reviews.llvm.org/D82352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D82352: [clangd] Make background index thread count calculation clearer

2020-06-23 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added reviewers: kadircet, aganea. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This confusion was inadvertently introduced in a change to the heavyweight_hardware_concurrency