[PATCH] D82606: [clangd] Config: config struct propagated through Context

sammccall added a comment. Thanks, reverted and looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82606/new/ https://reviews.llvm.org/D82606 ___ cfe-commits mailing list

[PATCH] D82606: [clangd] Config: config struct propagated through Context

thakis added a comment. The test fails on mac and win: http://45.33.8.238/mac/16341/step_9.txt http://45.33.8.238/win/18704/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82606/new/ https://reviews.llvm.org/D82606

[PATCH] D82606: [clangd] Config: config struct propagated through Context

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG9963d93b0731: [clangd] Config: config struct propagated through Context (authored by sammccall). Changed prior to commit:

[PATCH] D82606: [clangd] Config: config struct propagated through Context

sammccall marked 2 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:187 + // FIXME: remove const_cast once unique_function is const-compatible. + for (auto : const_cast(Config::current()).CompileFlags.Edits) +

[PATCH] D82606: [clangd] Config: config struct propagated through Context

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. oops, thought I've stamped it last time. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:187 + // FIXME: remove const_cast once unique_function is

[PATCH] D82606: [clangd] Config: config struct propagated through Context

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:187 + // FIXME: remove const_cast once unique_function is const-compatible. + for (auto : const_cast(Config::current()).CompileFlags.Edits) +

[PATCH] D82606: [clangd] Config: config struct propagated through Context

kadircet added a comment. Thanks, LGTM. Just a question around the order of config vs other mangling. Comment at: clang-tools-extra/clangd/CompileCommands.cpp:187 + // FIXME: remove const_cast once unique_function is const-compatible. + for (auto :

[PATCH] D82606: [clangd] Config: config struct propagated through Context

sammccall updated this revision to Diff 273543. sammccall added a comment. config() -> Config::current(). "config" already names a namespace. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82606/new/ https://reviews.llvm.org/D82606 Files:

[PATCH] D82606: [clangd] Config: config struct propagated through Context

sammccall created this revision. sammccall added reviewers: hokein, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This introduces the "semantic form" of config exposed to features, contrasted with the