[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

2020-07-08 Thread Amy Kwan via Phabricator via cfe-commits
amyk marked 2 inline comments as done. amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:79 +vector signed int test_vec_dive_si(void) { + // CHECK: @llvm.ppc.altivec.vdivesw(<4 x i32> + // CHECK-NEXT: ret <4 x i32> lei wrote: >

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

2020-07-08 Thread Lei Huang via Phabricator via cfe-commits
lei added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:79 +vector signed int test_vec_dive_si(void) { + // CHECK: @llvm.ppc.altivec.vdivesw(<4 x i32> + // CHECK-NEXT: ret <4 x i32> why does the ck stops matching at the first param?

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

2020-06-30 Thread Amy Kwan via Phabricator via cfe-commits
amyk updated this revision to Diff 274680. amyk edited the summary of this revision. amyk added a parent revision: D82576: [PowerPC][Power10] Implement low-order Vector Modulus Builtins, and add Vector Multiply/Divide/Modulus Builtins Tests. amyk added a comment. Rebase patch, remove MC tests fro

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

2020-06-25 Thread Amy Kwan via Phabricator via cfe-commits
amyk updated this revision to Diff 273578. amyk added a comment. Addressed Anil's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82609/new/ https://reviews.llvm.org/D82609 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/Headers/altivec.h clang/test/CodeGen/bui

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

2020-06-25 Thread Amy Kwan via Phabricator via cfe-commits
amyk marked 2 inline comments as done. amyk added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:18 + // CHECK-NEXT: ret <4 x i32> + return vec_dive(vsia, vsib); +} anil9 wrote: > I may be wrong but where are the variables declared ? I

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

2020-06-25 Thread Anil Mahmud via Phabricator via cfe-commits
anil9 added inline comments. Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:18 + // CHECK-NEXT: ret <4 x i32> + return vec_dive(vsia, vsib); +} I may be wrong but where are the variables declared ? I do not see the variables delclared above in the fil

[PATCH] D82609: [PowerPC][Power10] Implement Vector Multiply High/Divide Extended Builtins in LLVM/Clang

2020-06-25 Thread Amy Kwan via Phabricator via cfe-commits
amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, nemanjai, lei, saghir. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. This patch implements the following function prototypes to utilize the `vmulh[s|u][w|d]` and `vdive[s|u][w|d]