[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

guopeilin added a comment. In D82657#2956851 , @sammccall wrote: > In D82657#2956751 , @guopeilin wrote: > >> Hi @hokein , I encounter a bug when clang parses enum and I have been >> recorded in https://bugs.llvm.o

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

sammccall added a comment. In D82657#2956751 , @guopeilin wrote: > Hi @hokein , I encounter a bug when clang parses enum and I have been > recorded in https://bugs.llvm.org/show_bug.cgi?id=51554. I added a comment on the bug and sent https://reviews.llvm

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

guopeilin added a comment. Hi @hokein , I encounter a bug when clang parses enum and I have been recorded in https://bugs.llvm.org/show_bug.cgi?id=51554. The source code like the following: enum E { e = E() }; int main() { return 0; } Some error message are expected like the following

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein added a comment. In D82657#2240603 , @vvereschaka wrote: > Hi @hokein, > > sorry, but looks like your changes break one of libc++ tests on ARM cross > toolchain build on Windows: `libc++::function_type_default_deleter.fail.cpp` > Here is the first

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

vvereschaka added a comment. Hi @hokein, sorry, but looks like your changes break one of libc++ tests on ARM cross toolchain build on Windows: `libc++::function_type_default_deleter.fail.cpp` Here is the first failed build: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/945 I

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

This revision was automatically updated to reflect the committed changes. Closed by commit rG09e7fe9859b4: [AST][RecoveryAST] Preserve the type by default for recovery expression. (authored by hokein). Herald added a subscriber: dang. Changed prior to commit: https://reviews.llvm.org/D82657?vs=

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein added inline comments. Comment at: clang/test/SemaCXX/abstract.cpp:282 - void foo( C& c ) {} + void foo( C& c ) {} // expected-note {{candidate function not viable: expects an l-value for 1st argument}} sammccall wrote: > the new diagnostics are cor

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein updated this revision to Diff 287030. hokein added a comment. update a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82657/new/ https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CXX/tem

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein updated this revision to Diff 287029. hokein marked 2 inline comments as done. hokein added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82657/new/ https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInvoc

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. New diagnostics are really good :-) Comment at: clang/test/SemaCXX/abstract.cpp:282 - void foo( C& c ) {} + void foo( C& c ) {} // expected-note {{candidate functio

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein added a comment. > As you said, we can't land this before the branch cut, and we shouldn't land > this until we've run internal experiments to show it's not horribly crashy. The internal experiment result is good, I think we're close to land it. After a new rebase, we need to adjust more

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein updated this revision to Diff 284995. hokein added a comment. rebase and adjust more existing diagnostic tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82657/new/ https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInv

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

sammccall added a comment. As you said, we can't land this before the branch cut, and we shouldn't land this until we've run internal experiments to show it's not horribly crashy. Comment at: clang/test/CXX/temp/temp.constr/temp.constr.order/function-templates.cpp:71 +// expe

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/test/CXX/temp/temp.decls/temp.variadic/fixed-expansion.cpp:129 + S &s1 = f({}, 0, 0.0); // expected-error {{no matching function}} \ + expected-

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein updated this revision to Diff 276733. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82657/new/ https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CXX/temp/temp.cons

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. DO NOT SUBMIT. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CXX/temp/temp.constr/temp.constr.order/funct