[PATCH] D82659: Fix missing build dependency on omp_gen.

michele.scandale added a comment. Uhm.. it looks like it is not needed anymore. In the `LLVMConfig.cmake` that will be installed a `intrinsics_gen` and `omp_gen` custom targets are created for exactly the purpose of allowing out-of-tree or standalone builds to freely depend on them. The Clang c

[PATCH] D82659: Fix missing build dependency on omp_gen.

clementval added a comment. In D82659#2138228 , @michele.scandale wrote: > In D82659#2136999 , @clementval > wrote: > > > Looks good but just one question ... When clang is built as standalone it > > does not bui

[PATCH] D82659: Fix missing build dependency on omp_gen.

michele.scandale added a comment. In D82659#2136999 , @clementval wrote: > Looks good but just one question ... When clang is built as standalone it > does not build the OpenMP part inside Clang? I haven't seen any code to avoid > compiling the OpenMP pa

[PATCH] D82659: Fix missing build dependency on omp_gen.

clementval added a comment. In D82659#2136909 , @michele.scandale wrote: > Why `omp_gen` is now a dependency of `clang-tablegen-targets` rather than > being in the `LLVM_COMMON_DEPENDS` list like `clang-tablegen-targets`? > > Moreover I've noticed that w

[PATCH] D82659: Fix missing build dependency on omp_gen.

michele.scandale added a comment. Why `omp_gen` is now a dependency of `clang-tablegen-targets` rather than being in the `LLVM_COMMON_DEPENDS` list like `clang-tablegen-targets`? Moreover I've noticed that with the recent changes where `omp_gen` has been added as a dependency in several librar

[PATCH] D82659: Fix missing build dependency on omp_gen.

clementval added a comment. In D82659#2130022 , @simon_tatham wrote: > @jdoerfert , @clementval : over in D83032 > is a polished-up version of the script I used to check where the missing deps > needed to go. Might be u

[PATCH] D82659: Fix missing build dependency on omp_gen.

simon_tatham added a comment. @jdoerfert , @clementval : over in D83032 is a polished-up version of the script I used to check where the missing deps needed to go. Might be useful for the next problem of this kind. But I'm not sure who to get to review it; perh

[PATCH] D82659: Fix missing build dependency on omp_gen.

jdoerfert added a comment. Thank you both for figuring this out! *Much* appreciated! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659 ___ cfe-commits mailing li

[PATCH] D82659: Fix missing build dependency on omp_gen.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e6f19fd8390: Fix missing build dependency on omp_gen. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.

[PATCH] D82659: Fix missing build dependency on omp_gen.

simon_tatham added a comment. [facepalm] Thank you. I carefully //wrote// a revised description, but forgot to upload it to this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659 ___

[PATCH] D82659: Fix missing build dependency on omp_gen.

simon_tatham added a comment. In D82659#2125618 , @clementval wrote: > LGTM. So later the DEPENDS omp_gen that are in clang subdirectories could be > removed right? That seems likely. I'm thinking what I should probably do is to polish up my checking s

[PATCH] D82659: Fix missing build dependency on omp_gen.

clementval added a comment. @simon_tatham Can you just update the description so it is consistent with your fix when it lands? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D82659: Fix missing build dependency on omp_gen.

clementval accepted this revision. clementval added a comment. LGTM. So later the DEPENDS omp_gen that are in clang subdirectories could be removed right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82659/new/ https://reviews.llvm.org/D82659

[PATCH] D82659: Fix missing build dependency on omp_gen.

simon_tatham updated this revision to Diff 274739. simon_tatham added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Here's a completely different patch, which adds all the missing dependencies on `OMP.h.inc` in the `clang` subdirectory in one go. Repository: