This revision was automatically updated to reflect the committed changes.
Closed by commit rGe73c3bb06b5a: [AArch64][SVE] Add bfloat16 to outstanding
tuple vector intrinsics (authored by c-rhodes).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82665/
fpetrogalli accepted this revision.
fpetrogalli added a comment.
This revision is now accepted and ready to land.
LGTM, thank you.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82665/new/
https://reviews.llvm.org/D82665
___
cfe-commits mail
c-rhodes updated this revision to Diff 274138.
c-rhodes added a comment.
Changes:
- Use function attribute for `+bf16` target feature.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82665/new/
https://reviews.llvm.org/D82665
Files:
clang/include/clang/Basic/arm_sve.td
clang/test/Co
c-rhodes added inline comments.
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll:100
+
+define @test_svcreate2_bf16_vec0(i1 %p, %z0, %z1) local_unnamed_addr #0 {
+; CHECK-LABEL: test_svcreate2_bf16_vec0:
fpetrogalli wrote:
> nit: remove `lo
fpetrogalli added inline comments.
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll:1
-; RUN: llc -mtriple aarch64 -mattr=+sve -asm-verbose=1 < %s | FileCheck %s
+; RUN: llc -mtriple aarch64 -mattr=+sve,+bf16 -asm-verbose=1 < %s | FileCheck
%s
-
c-rhodes updated this revision to Diff 274081.
c-rhodes added a comment.
Changes:
- Cover all indexes in get/set ACLE tests
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82665/new/
https://reviews.llvm.org/D82665
Files:
clang/include/clang/Basic/arm_sve.td
clang/test/CodeGen/aarch
c-rhodes added inline comments.
Comment at:
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_create2-bfloat.c:9
+// A simple used,unused... macro, long enough to represent any SVE builtin.
+#define SVE_ACLE_FUNC(A1,A2_UNUSED,A3,A4_UNUSED) A1##A3
+#else
fpetrog
fpetrogalli added inline comments.
Comment at:
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_create2-bfloat.c:9
+// A simple used,unused... macro, long enough to represent any SVE builtin.
+#define SVE_ACLE_FUNC(A1,A2_UNUSED,A3,A4_UNUSED) A1##A3
+#else
Nit:
c-rhodes created this revision.
c-rhodes added reviewers: sdesmalen, kmclaughlin, fpetrogalli.
Herald added subscribers: danielkiss, psnobl, rkruppe, kristof.beyls, tschuett.
Herald added a reviewer: efriedma.
Herald added projects: clang, LLVM.
- svget2/3/4
- svset2/3/4
- svcreate2/3/4
- svundef/