[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers abandoned this revision.
nickdesaulniers added a comment.

Reverted in 7c2cb1448ad2d20e251db5e3ae4a0c84c12aa970 
, relanded 
in 7b8cf98b4a9a2f5ea3667fdbf913a4f8952ed36a 
.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82690/new/

https://reviews.llvm.org/D82690



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet added a comment.

yes let's revert dffc1420451f674 
 and 
reland with this change included, also please keep the `Differential Revision: 
https://reviews.llvm.org/D80681` line on the commit message, so that it gets 
associated with the previous review, as it contains a lot of context.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82690/new/

https://reviews.llvm.org/D82690



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added a comment.

Alternatively, I could revert dffc1420451f674 
, and 
reland with this hunk? That way if a revert is necessary in the future, it's 
only one. Also so that before/after metrics are together and not across two 
separate patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82690/new/

https://reviews.llvm.org/D82690



___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers created this revision.
nickdesaulniers added a reviewer: kadircet.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
nickdesaulniers added a comment.

Alternatively, I could revert dffc1420451f674 
, and 
reland with this hunk? That way if a revert is necessary in the future, it's 
only one. Also so that before/after metrics are together and not across two 
separate patches.


Rebasing D80681  on D82497 
+D82498 , I 
made a mistake and dropped this hunk
accidentally.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82690

Files:
  clang/lib/Basic/SourceManager.cpp


Index: clang/lib/Basic/SourceManager.cpp
===
--- clang/lib/Basic/SourceManager.cpp
+++ clang/lib/Basic/SourceManager.cpp
@@ -896,10 +896,8 @@
 SLocOffset < getLocalSLocEntry(MiddleIndex + 1).getOffset()) {
   FileID Res = FileID::get(MiddleIndex);
 
-  // If this isn't a macro expansion, remember it.  We have good locality
-  // across FileID lookups.
-  if (!LocalSLocEntryTable[MiddleIndex].isExpansion())
-LastFileIDLookup = Res;
+  // Remember it.  We have good locality across FileID lookups.
+  LastFileIDLookup = Res;
   NumBinaryProbes += NumProbes;
   return Res;
 }


Index: clang/lib/Basic/SourceManager.cpp
===
--- clang/lib/Basic/SourceManager.cpp
+++ clang/lib/Basic/SourceManager.cpp
@@ -896,10 +896,8 @@
 SLocOffset < getLocalSLocEntry(MiddleIndex + 1).getOffset()) {
   FileID Res = FileID::get(MiddleIndex);
 
-  // If this isn't a macro expansion, remember it.  We have good locality
-  // across FileID lookups.
-  if (!LocalSLocEntryTable[MiddleIndex].isExpansion())
-LastFileIDLookup = Res;
+  // Remember it.  We have good locality across FileID lookups.
+  LastFileIDLookup = Res;
   NumBinaryProbes += NumProbes;
   return Res;
 }
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits