[PATCH] D82711: [clang-tidy] Fix hicpp-named-paramater

2020-06-29 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1f228e572da2: [clang-tidy] Fix hicpp-named-paramater (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82711/new/

[PATCH] D82711: [clang-tidy] Fix hicpp-named-paramater

2020-06-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D82711#2119714 , @njames93 wrote: > In D82711#2119651 , @aaron.ballman > wrote: > > > I do

[PATCH] D82711: [clang-tidy] Fix hicpp-named-paramater

2020-06-29 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. In D82711#2119651 , @aaron.ballman wrote: > I do not understand the justification here -- `IdentifierNamingCheck` and > `NamedParameterCheck` are two different checks. How do you know that this > swap continues to honor the

[PATCH] D82711: [clang-tidy] Fix hicpp-named-paramater

2020-06-29 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. I do not understand the justification here -- `IdentifierNamingCheck` and `NamedParameterCheck` are two different checks. How do you know that this swap continues to honor the HIC++ coding standard? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82711: [clang-tidy] Fix hicpp-named-paramater

2020-06-29 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, jbcoe. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Currently this alias instantiates the readability-identifier-naming check, just swap it out to use the readability-named-paramater