This revision was automatically updated to reflect the committed changes.
Closed by commit rG121a49d839d7: [LiveDebugValues] Add switches for using
instr-ref variable locations (authored by jmorse).
Changed prior to commit:
https://reviews.llvm.org/D83048?vs=286814&id=287655#toc
Repository:
djtodoro accepted this revision.
djtodoro added a comment.
This revision is now accepted and ready to land.
nit included, otherwise lgtm, thanks!
Comment at: llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp:45
+ ~LiveDebugValues()
+ {
+if (TheImpl)
is
jmorse updated this revision to Diff 286814.
jmorse added a comment.
Herald added a subscriber: dang.
Add a test for the driver -Xclang option. As far as I understand this, we're
just checking that the switch is accepted by the driver, not that it does
anything in particular (please correct me i
jmorse updated this revision to Diff 276040.
jmorse added a comment.
(Rebase, only affecting LiveDebugValues.cpp)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83048/new/
https://reviews.llvm.org/D83048
Files:
clang/include/clang/Basic/CodeGenOptions.def
clang/include/clang/Driver/
djtodoro added a comment.
Please add a test case for the Driver option (you can take a look into existing
ones within `clang/test/Driver/`).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83048/new/
https://reviews.llvm.org/D83048
__
jmorse created this revision.
jmorse added reviewers: aprantl, vsk, probinson, Orlando, StephenTozer,
TWeaver, djtodoro.
Herald added subscribers: llvm-commits, cfe-commits, hiraditya.
Herald added projects: clang, LLVM.
jmorse added a parent revision: D83047: [LiveDebugValues] 2/4 Add
instructio
