[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

2020-07-02 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli marked an inline comment as done. fpetrogalli added a comment. In D83079#2129371 , @SjoerdMeijer wrote: > I haven't looked into details of these arch extensions yet, will do that > tomorrow, but I don't think there's any disagreement, i.e.,

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

2020-07-02 Thread Sjoerd Meijer via Phabricator via cfe-commits
SjoerdMeijer added a comment. I haven't looked into details of these arch extensions yet, will do that tomorrow, but I don't think there's any disagreement, i.e., these options and their behaviour are synchronised with the GCC community. Thus, it's better if you remove this wording from both

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

2020-07-02 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:118 + case llvm::AArch64::ArchKind::ARMV8_6A: +Features.push_back("+i8mm"); +Features.push_back("+bf16"); Looking at what Clang emits for e.g. `-march=armv8.5-a`,

[PATCH] D83079: [clang] Default target features implied by `-march` on AArch64.

2020-07-02 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, efriedma, SjoerdMeijer. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. This patch is trying to align the interpretation of `-march` on AArch64 to what GCC has, in terms of