[PATCH] D83143: [clangd] Fix hover crash on invalid decls

2020-07-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83143/new/ https://reviews.llvm.org/D83143 __

[PATCH] D83143: [clangd] Fix hover crash on invalid decls

2020-07-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG50ba9f994c6f: [clangd] Fix hover crash on invalid decls (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83143/new/ https://reviews.llv

[PATCH] D83143: [clangd] Fix hover crash on invalid decls

2020-07-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet updated this revision to Diff 275448. kadircet added a comment. Inline OffsetBits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83143/new/ https://reviews.llvm.org/D83143 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cla

[PATCH] D83143: [clangd] Fix hover crash on invalid decls

2020-07-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This also changes the way we display Size and Offset to be independent. Repository: rG LLVM Github