This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb36e22d64458: [clangd] Extract BackgroundIndex::Options
struct. NFC (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D83
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:184
+TFS, CDB,
BackgroundIndexStorage::createDiskBackedStorageFactory(
[&CDB](llvm::StringRef File) { return CDB.getProje
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:184
+TFS, CDB,
BackgroundIndexStorage::createDiskBackedStorageFactory(
[&CDB](llvm::StringRef File) { return CDB.getPro
kadircet accepted this revision.
kadircet marked an inline comment as done.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks for doing this!
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:184
+TFS, CDB,
BackgroundIndexSto
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
I've dropped the background context parameter, since we in practice just pass
the
current context the
