[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch, I've gone ahead and commit on your behalf in a44161692ae879068d4086a7e568a348800ba01d . CHANGES SINCE LAST ACTION

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Re-accepting the changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping @njames93. Does this look ok to you? If so, could you please help me with the commit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp marked an inline comment as done. tetsuo-cpp added a comment. @aaron.ballman Thanks! I took your suggestion and I think this looks cleaner. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp updated this revision to Diff 280082. tetsuo-cpp added a comment. Cleanup check conditional. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 Files: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

aaron.ballman added a comment. LGTM, though I have a possible code simplification if you think it's an improvement. Comment at: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp:78 + + if (const auto *DeclRef = Result.Nodes.getNodeAs("expr")) { +

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping. Could I please get this looked at? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp updated this revision to Diff 276022. tetsuo-cpp added a comment. Address comments: Rename variables, remove unnecessary tests and avoid unnecessary check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 Files:

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

njames93 added a comment. Thanks for working on this. There seems to be many places in this check where names are confusing, `Var` referring to a `MemberExpr`, `DeclRef` refering to a `MemberExpr`. I'd prefer if the names that you have added were renamed to something more in line with what

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp updated this revision to Diff 275592. tetsuo-cpp added a comment. Remove the unnecessary template. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 Files: clang-tools-extra/clang-tidy/bugprone/BoolPointerImplicitConversionCheck.cpp

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp created this revision. tetsuo-cpp added reviewers: njames93, MaskRay. tetsuo-cpp added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=45189 This patch is adding support for members to the