[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

This revision was automatically updated to reflect the committed changes. Closed by commit rG254b016c6561: [clangd] More complete fix for hover crashes on invalid record. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83189/new/

[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:677 HI.Size = Size->getQuantity(); - if (!FD->isInvalidDecl()) HI.Offset = Ctx.getFieldOffset(FD) / 8; + } kadircet w

[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

hokein updated this revision to Diff 275718. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83189/new/ https://reviews.llvm.org/D83189 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/u

[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:677 HI.Size = Size->getQuantity(); - if (!FD->isInvalidDecl()) HI.Offset = Ctx.getFieldOffset(FD) / 8; + } hokein wrote: > kadircet wrote: > > could you mov

[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

hokein updated this revision to Diff 275664. hokein marked 2 inline comments as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83189/new/ https://reviews.llvm.org/D83189 Files: clang-tools-extra/clan

[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:677 HI.Size = Size->getQuantity(); - if (!FD->isInvalidDecl()) HI.Offset = Ctx.getFieldOffset(FD) / 8; + } kadircet wrote: > could you move this out of the if

[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

kadircet added a comment. thanks for doing this ! Comment at: clang-tools-extra/clangd/Hover.cpp:665 if (auto *RD = llvm::dyn_cast(&ND)) { if (auto Size = Ctx.getTypeSizeInCharsIfKnown(RD->getTypeForDecl())) HI.Size = Size->getQuantity(); i think

[PATCH] D83189: [clangd] More complete fix for hover crashes on invalid record.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We should not call getFieldOffset on invalid record decls. Repository: rG LLVM Github Monorepo https://reviews.llvm.o