[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

alexfh added a comment. In D83223#2147306 , @aaron.ballman wrote: > In D83223#2147247 , @njames93 wrote: > > > In D83223#2147072 , @aaron.ballman > > wrote: > > > > > > /

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

aaron.ballman added a comment. In D83223#2147247 , @njames93 wrote: > In D83223#2147072 , @aaron.ballman > wrote: > > > > // This is not identified as a license comment as the > > > // block is followed by code

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

njames93 updated this revision to Diff 277411. njames93 added a comment. - Added expect no changes test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83223/new/ https://reviews.llvm.org/D83223 Files: clang-tools-extra/clang-tidy/utils/HeaderGuar

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

njames93 marked 2 inline comments as done. njames93 added a comment. In D83223#2147072 , @aaron.ballman wrote: > > // This is not identified as a license comment as the > > // block is followed by code. > > void foo(); > > FWIW: > https://github.co

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

aaron.ballman added a comment. > // This is not identified as a license comment as the > // block is followed by code. > void foo(); FWIW: https://github.com/GrammaTech/gtirb-pprinter/blob/master/include/gtirb_pprinter/AttPrettyPrinter.hpp or https://github.com/GrammaTech/gtirb/blob/maste

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

njames93 updated this revision to Diff 277348. njames93 added a comment. Added /**/ style license comment test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83223/new/ https://reviews.llvm.org/D83223 Files: clang-tools-extra/clang-tidy/Cla

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/HeaderGuard.cpp:313 continue; - + StringRef Opening = AddNewLine == NewLineInsertions::None ? "#ifndef " + : AddNewLine

[PATCH] D83223: [clang-tidy] Header guard check can skip past license comment

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, bkramer, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Add an option for header guard derived checks to control whether to skip past a license comment when adding a guar