This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rG69c22edb7d30: [clangd] Enable reading config from files
behind a flag (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.org/D83233?vs=275
hokein accepted this revision.
hokein added a comment.
looks like you didn't upload the latest version.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83233/new/
https://reviews.llvm.org/D83233
___
cfe-
sammccall marked 4 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:436
+"Project config is from a .clangd file in the project directory.\n"
+"User config is from clangd/config.yaml in the following
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:700
+ProviderStack.push_back(
+config::Provider::fromAncestorRelativeYAMLFiles(".clangd", TFS));
+llvm::SmallString<256> UserConfig;
should we first update th
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LG from my side
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83233/new/
https://reviews.llvm.org/D83233
hokein added inline comments.
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:436
+"Project config is from a .clangd file in the project directory.\n"
+"User config is from clangd/config.yaml in the following
directories:\n"
+"\tWindows: %USERPRO
sammccall created this revision.
sammccall added reviewers: kadircet, hokein.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D83233
Files:
clang-tools-ex
