This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG577f8b157a03: [Fixed Point] Add codegen for fixed-point
shifts. (authored by ebevhan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
ebevhan updated this revision to Diff 286968.
ebevhan added a comment.
Revamped patch. It's now based on the FixedPointBuilder.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83294/new/
https://reviews.llvm.org/D83294
Files:
ebevhan marked an inline comment as done.
ebevhan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3857
+
+ // TODO: This misses out on the sanitizer check below.
+ if (Ops.isFixedPointOp())
leonardchan wrote:
> I don't suppose you could
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3857
+
+ // TODO: This misses out on the sanitizer check below.
+ if (Ops.isFixedPointOp())
I don't suppose you could file a bug for this and CC me on it so we can
remember to
ebevhan marked an inline comment as done.
ebevhan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3603-3604
auto ResultFixedSema = Ctx.getFixedPointSemantics(ResultTy);
- auto CommonFixedSema = LHSFixedSema.getCommonSemantics(RHSFixedSema, true);
+
leonardchan added inline comments.
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3603-3604
auto ResultFixedSema = Ctx.getFixedPointSemantics(ResultTy);
- auto CommonFixedSema = LHSFixedSema.getCommonSemantics(RHSFixedSema, true);
+ auto CommonFixedSema =
ebevhan created this revision.
ebevhan added reviewers: rjmccall, leonardchan, bjope.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch adds codegen to Clang for fixed-point shift
operations.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D83294
