[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

rjmccall added a comment. Pointer authentication can also make structs non-trivial to copy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83448/new/ https://reviews.llvm.org/D83448 ___ cfe-commits mailin

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

dblaikie added a comment. In D83448#2357574 , @ahatanak wrote: > C structs with ObjC pointer fields are non-trivial when ARC is enabled since > construction, destruction, and copy are non-trivial (see > https://reviews.llvm.org/D41228). As far as I know,

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

ahatanak added a comment. C structs with ObjC pointer fields are non-trivial when ARC is enabled since construction, destruction, and copy are non-trivial (see https://reviews.llvm.org/D41228). As far as I know, this is limited to ObjC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

dblaikie added a comment. Idle curiosity: The patch description says "non-trivial C struct temporaries" - can C have non-trivial structs? Or is this limited to Objective C (judging/guessing by the tests)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG71e1a56de153: [CodeGen] Emit destructor calls to destruct non-trivial C struct (authored by ahatanak, committed by --local ).

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83448/new/ https://reviews.llvm.org/D83448

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

ahatanak added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83448/new/ https://reviews.llvm.org/D83448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. rdar://problem/64989559 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83448 Files: clang/lib/CodeGen/CGExprAgg.cpp