[PATCH] D83755: [clangd] Cache config files for 5 seconds, without revalidating with stat.

2020-07-14 Thread Sam McCall via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rGff616f74c3b4: [clangd] Cache config files for 5 seconds, without revalidating with stat. (authored by sammccall). Changed prior to commit:

[PATCH] D83755: [clangd] Cache config files for 5 seconds, without revalidating with stat.

2020-07-14 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, LGTM Comment at: clang-tools-extra/clangd/ConfigProvider.cpp:24 +// + looks like an unwated artifact Comment at:

[PATCH] D83755: [clangd] Cache config files for 5 seconds, without revalidating with stat.

2020-07-14 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is motivated by: - code completion: nice to do no i/o on the request path - background index: