[PATCH] D83772: [Windows] Fix limit on command line size

This revision was automatically updated to reflect the committed changes. Closed by commit rGdab898f9ab62: [Windows] Fix limit on command line size (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/

[PATCH] D83772: [Windows] Fix limit on command line size

max-kudr accepted this revision. max-kudr added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 ___ cfe-commits mailing list

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff added reviewers: k8stone, max-kudr. sepavloff added subscribers: max-kudr, k8stone. sepavloff added a comment. @k8stone @max-kudr Could you please review the changes for LLDB? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff updated this revision to Diff 279709. sepavloff added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Added changes for LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/

[PATCH] D83772: [Windows] Fix limit on command line size

max-kudr added a comment. Thank you! @sepavloff reverted it in revision ac0edc55887b6961ad90fd51f349c9587b1a8a7a Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/

[PATCH] D83772: [Windows] Fix limit on command line size

amccarth added a comment. In D83772#2164685 , @max-kudr wrote: > This commit is now failing LLDB Windows buildbot > builds > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17702.

[PATCH] D83772: [Windows] Fix limit on command line size

max-kudr added a comment. This commit is now failing LLDB Windows buildbot builds http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/17702. Please fix or revert.

[PATCH] D83772: [Windows] Fix limit on command line size

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4020ef7c474: [Windows] Fix limit on command line size (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff updated this revision to Diff 278221. sepavloff added a comment. Fixed unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 Files: llvm/include/llvm/Support/Program.h

[PATCH] D83772: [Windows] Fix limit on command line size

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks! I know it was more work, but I think unifying the command line generation to work the same in both cases will avoid future surprises. Repository: rG LLVM Github Monorepo

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff updated this revision to Diff 278132. sepavloff added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 Files: llvm/include/llvm/Support/Program.h

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff added a comment. Thank you for your detailed feedback! > Round down to 32,000 to leave us wiggle room. As there is no requirement to use response files as rarely as possible, the choice of the limit is an implementation detail. Having some wiggle room is a good idea in this case. >

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff updated this revision to Diff 278117. sepavloff added a comment. Addressed reviewer's notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 Files: llvm/include/llvm/Support/Program.h

[PATCH] D83772: [Windows] Fix limit on command line size

amccarth added a comment. I'm jumping in since rnk is on leave and (I believe) zturner is less focused on these issues than he used to be. Thanks for tracking down the cause of this bug. I have some concerns: - We're trying to cut it right up to the hard limit. That seems an unnecessary

[PATCH] D83772: [Windows] Fix limit on command line size

sepavloff created this revision. sepavloff added reviewers: rnk, zturner. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Documentation on CreateProcessW states that maximal size of command line is 32767 characters including ternimation null character. In the