sammccall added a comment.
There are lots of choices and overlapping ideas for how the protocol should
look, little urgency (it isn't going to make clangd 11), and few concrete use
cases to evaluate the options.
Let's table this for now and let the ideas sink in and more use cases crop up.
I d
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1220
CDB->setCompileCommand(File, std::move(New));
ModifiedFiles.insert(File);
}
sammccall wrote:
> kadircet wrote:
> > nit: maybe just set `ReparseAllFile
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1220
CDB->setCompileCommand(File, std::move(New));
ModifiedFiles.insert(File);
}
kadircet wrote:
> nit: maybe
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1220
CDB->setCompileCommand(File, std::move(New));
ModifiedFiles.insert(File);
}
nit: maybe just set `ReparseAllFiles` in here too, and change the conditio
sammccall created this revision.
sammccall added a reviewer: kadircet.
Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
We support sending fragments in initialize and workspace/didChangeConfiguration.
Sadly no workspace/co
