vsavchenko added a comment.
The same thing with the commit message here, it would be better as just "Change"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83877/new/
https://reviews.llvm.org/D83877
vsavchenko added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:198
void SmartPtrModeling::handleSwap(const CallEvent ,
CheckerContext ) const {
I think it would be good to add some
xazax.hun added inline comments.
Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:964-965
+
+ template
+ void swap(unique_ptr , unique_ptr ) noexcept {
+x.swap(y);
NoQ wrote:
> You seem to be relying on the fact that global `std::swap`
NoQ added inline comments.
Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:964-965
+
+ template
+ void swap(unique_ptr , unique_ptr ) noexcept {
+x.swap(y);
You seem to be relying on the fact that global `std::swap` is implemented in
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: clang/test/Analysis/Inputs/system-header-simulator-cxx.h:965
+ template
+ void swap(unique_ptr , unique_ptr ) noexcept {
+x.swap(y);
vrnithinkumar marked an inline comment as done.
vrnithinkumar added inline comments.
Comment at: clang/test/Analysis/smart-ptr.cpp:131
+}
\ No newline at end of file
I will fix this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
vrnithinkumar created this revision.
Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso,
dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet,
baloghadamsoftware, xazax.hun.
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
