varungandhi-apple added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84087/new/
https://reviews.llvm.org/D84087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb907ad539a90: [NFC] Clean up doc comment and implementation
for Module::isSubModuleOf. (authored by aprantl).
Changed prior to commit:
https://reviews.llvm.org/D84087?vs=278972=279659#toc
Repository:
varungandhi-apple added a comment.
(Could you land the patch if it looks good? I don't have commit access.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84087/new/
https://reviews.llvm.org/D84087
___
varungandhi-apple marked an inline comment as done.
varungandhi-apple added inline comments.
Comment at: clang/lib/Basic/Module.cpp:176
bool Module::isSubModuleOf(const Module *Other) const {
- const Module *This = this;
- do {
+ for (const Module *This = this; This !=
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Basic/Module.cpp:176
bool Module::isSubModuleOf(const Module *Other) const {
- const Module *This = this;
- do {
+ for (const Module *This =
varungandhi-apple updated this revision to Diff 278972.
varungandhi-apple added a comment.
Updated commit message with reviewer information and revision link.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84087/new/
https://reviews.llvm.org/D84087
varungandhi-apple created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D84087
Files:
clang/include/clang/Basic/Module.h
clang/lib/Basic/Module.cpp
Index: clang/lib/Basic/Module.cpp
