eduucaldas updated this revision to Diff 283989.
eduucaldas added a comment.
Last version sent upstream
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84348/new/
https://reviews.llvm.org/D84348
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
eduucaldas updated this revision to Diff 283875.
eduucaldas added a comment.
rebase to add this commit from a further patch
- [SyntaxTree] Fix crash on name specifier.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84348/new/
https://reviews.llvm.o
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:789
+// Remove "::" from the `SourceRange`
+SR.setEnd(SR.getEnd().getLocWithOffset(-1));
+
Newbie mistake. Corrected in latter commit
Repository:
rG LLVM Github Monor
eduucaldas updated this revision to Diff 283622.
eduucaldas added a comment.
- Update comments to reflect change in API.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84348/new/
https://reviews.llvm.org/D84348
Files:
clang/include/clang/Tooling/
eduucaldas marked 2 inline comments as done.
eduucaldas added inline comments.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:834
+ // FIXME: I feel like this could be upstreamed.
+ SourceRange getUnqualifiedIdSourceRange(DeclRefExpr *S) {
+if (S->hasExplicitTemplateArg
eduucaldas updated this revision to Diff 280899.
eduucaldas marked 9 inline comments as done.
eduucaldas added a comment.
- Answer code review
- Simpler logic for `getUnqualifiedIdSourceRange` and inline it
- Remove ambiguously named variable NNS
Repository:
rG LLVM Github Monorepo
CHANGES SI
gribozavr2 added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:295
syntax::NestedNameSpecifier *qualifier();
- // TODO after expose `id-expression` from `DependentScopeDeclRefExpr`:
// Add accessor for `template_opt`.
+ syntax::Leaf *templateKeyw
eduucaldas updated this revision to Diff 280511.
eduucaldas added a comment.
- Remove UnknownNameSpecifier, answer to comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84348/new/
https://reviews.llvm.org/D84348
Files:
clang/include/clang/To
eduucaldas updated this revision to Diff 280497.
eduucaldas added a comment.
- Improve getLocalSourceRange
- nested-name-specifier is now a ::-separated list of name-specifiers
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84348/new/
https://review
gribozavr2 added a comment.
What is this diff based on? On the left I see, for example,
NamespaceNameSpecifier, which is not in the repository yet.
Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:777
// FIXME: Support Microsoft's __super
- return new (allocator(
eduucaldas updated this revision to Diff 280216.
eduucaldas added a comment.
Update API to new nested-name-specifier grammar rule
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D84348/new/
https://reviews.llvm.org/D84348
Files:
clang/include/clang
eduucaldas added a reviewer: gribozavr2.
eduucaldas marked 6 inline comments as done.
eduucaldas added inline comments.
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:101-106
+ UnknownNameSpecifier,
+ GlobalNameSpecifier,
+ NamespaceNameSpecifier,
+ TypeNameSpecifier,
eduucaldas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D84348
Files:
clang/include/clang/Tooling/Syntax/Nodes.h
clang/lib/Tooling/Syntax/BuildTree.cpp
clang/lib/Tooling/Syntax/N
13 matches
Mail list logo