[PATCH] D84387: [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

hokein added a comment. > I'm not sure I love having the assertion for contains-errors every place that > handles dependent code in C. My feeling is that the assertion would help for understanding the code (comparing with documenting it somewhere), and we don't have too many places. Repositor

[PATCH] D84387: [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

hokein updated this revision to Diff 296611. hokein marked an inline comment as done. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84387/new/ https://reviews.llvm.org/D84387 Files: clang/lib/Sema/SemaCast.cpp cl

[PATCH] D84387: [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

sammccall added a comment. I'm not sure I love having the assertion for contains-errors every place that handles dependent code in C. We should certainly somehow document the reason dependence is possible, just as the possibility of overloads is documented. But the assertion seems pretty heavywe

[PATCH] D84387: [AST][RecoveryExpr] Part4: Suppress spurious "err_typecheck_expect_scalar_operand" diagnostic

hokein added a comment. In D84387#2220845 , @sammccall wrote: > Sorry for losing track of this. Where is CDependence defined? Is this stacked > on another patch? yes. Sorry for not being clear here, this is stacked on another patch. I have renamed these