[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-08-06 Thread Rainer Orth via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. ro marked 3 inline comments as done. Closed by commit rG710949482edb: [clang][Driver] Dont hardcode --as-needed/--no-as-needed on Illumos (authored by ro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-08-05 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-08-05 Thread Rainer Orth via Phabricator via cfe-commits
ro marked 3 inline comments as done. ro added a comment. In D84412#2193600 , @MaskRay wrote: > #clang does not have many people. You > might need to add people explicitly.. I always found finding reviewers sort of a

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-08-05 Thread Rainer Orth via Phabricator via cfe-commits
ro updated this revision to Diff 283232. ro added a comment. Incorporate review comments: clarify comment and arg name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412 Files:

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-08-04 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. #clang does not have many people. You might need to add people explicitly.. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:633 +static const char *getAsNeededOption(const ToolChain , bool ignore) { + //

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-08-04 Thread Rainer Orth via Phabricator via cfe-commits
ro added a reviewer: MaskRay. ro added a comment. Ping? It's been two weeks now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84412/new/ https://reviews.llvm.org/D84412 ___ cfe-commits mailing list

[PATCH] D84412: [clang][Driver] Don't hardcode --as-needed/--no-as-needed on Illumos

2020-07-23 Thread Rainer Orth via Phabricator via cfe-commits
ro created this revision. ro added a reviewer: clang. ro added a project: clang. Herald added subscribers: fedor.sergeev, jyknight. `ninja check-all` currently fails on Illumos: [84/716] Generating default/Asan-i386-inline-Test FAILED: