[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG90684d154516: [clangd] Collect references for externally visible main-file symbols (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! numbers and the patch LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84513/new/ https://reviews.llvm.org/D84513

[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

ArcsinX added a comment. In D84513#2172028 , @kadircet wrote: > thanks, this looks good in general, but it would be nice to make sure we are > not blowing the index memory and disk usage. > > could you grab some numbers for these two before/after this

[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

ArcsinX updated this revision to Diff 280713. ArcsinX added a comment. Remove version bump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84513/new/ https://reviews.llvm.org/D84513 Files: clang-tools-extra/clangd/index/SymbolCollector.cpp

[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

kadircet marked an inline comment as done. kadircet added a comment. thanks, this looks good in general, but it would be nice to make sure we are not blowing the index memory and disk usage. could you grab some numbers for these two before/after this patch? Comment at:

[PATCH] D84513: [clangd] Collect references for externally visible main-file symbols

ArcsinX created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Without this patch clangd does not collect references for main-file symbols if there is no public declaration in preamble.