[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

2020-07-29 Thread Nathan Ridge via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG89247792c5bd: [clang] Fix ConceptSpecializationExpr::getEndLoc() (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

2020-07-28 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 281123. nridge added a comment. Address review comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84613/new/ https://reviews.llvm.org/D84613 Files: clang/include/clang/AST/ExprConcepts.h

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

2020-07-27 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: clang/test/AST/ast-dump-concepts.cpp:14 // CHECK-NEXT: `-TemplateArgument {{.*}} type 'int' template R> Foo(R) requires(true); could you also verify what's the end loc for this case? Repository: rG LLVM

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

2020-07-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge created this revision. nridge added a reviewer: hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. It returned an invalid location in case of a constrained-parameter with no explicit arguments. Repository: rG LLVM Github Monorepo

[PATCH] D84613: [clang] Fix ConceptSpecializationExpr::getEndLoc()

2020-07-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. Spun off from D84136 . Depends on D84461 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84613/new/ https://reviews.llvm.org/D84613