[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

2021-11-11 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added a comment. In D8467#3125313 , @tstellar wrote: > In D8467#3095610 , @zixuan-wu wrote: > >> Hi, I am wondering could -fsized-deallocation this be enabled by default >> nowadays in 2021? > > Were you

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

2021-11-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. In D8467#3125471 , @rnk wrote: > In D8467#3125386 , @rjmccall wrote: > >> Conceptually, this is (and will always be) a platform decision. On Apple >> platforms, we have a formalized

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

2021-11-11 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D8467#3125386 , @rjmccall wrote: > Conceptually, this is (and will always be) a platform decision. On Apple > platforms, we have a formalized concept of deployment target, where specific > minimum OS versions support sized

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

2021-11-11 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Conceptually, this is (and will always be) a platform decision. On Apple platforms, we have a formalized concept of deployment target, where specific minimum OS versions support sized deallocation and others do not. On most other platforms, this is much vaguer —

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

2021-11-11 Thread Tom Stellard via Phabricator via cfe-commits
tstellar added a comment. In D8467#3095610 , @zixuan-wu wrote: > Hi, I am wondering could -fsized-deallocation this be enabled by default > nowadays in 2021? Were you planning to work on this? Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

2021-10-29 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In D8467#3095610 , @zixuan-wu wrote: > Hi, I am wondering could -fsized-deallocation this be enabled by default > nowadays in 2021? Yes, I think so. This should be a matter of adjusting the default in the driver. We should not bring

[PATCH] D8467: C++14: Disable sized deallocation by default due to ABI breakage

2021-10-28 Thread Zixuan Wu via Phabricator via cfe-commits
zixuan-wu added a comment. Herald added a subscriber: dang. Hi, I am wondering could -fsized-deallocation this be enabled by default nowadays in 2021? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8467/new/ https://reviews.llvm.org/D8467