[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added a comment. Sorry for taking so long. I created a patch that should fix the missing `SourceManager`: D99414 @rupprecht can you confirm this works for your use-case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added a comment. Thanks for reporting that, @rupprecht. I'll look into the issue in a couple of days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

rupprecht added a comment. I ran into this commit when integrating commits today (specifically, 97100646d1b4526de1eac3aacdb0b098739c6ec9 ) -- there's nothing wrong with this patch AFAICT, but I'm wondering if the error

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e3230ffa3ad: [clang][cli] Port DiagnosticOpts to new option parsing system (authored by jansvoboda11). Repository: rG LLVM Github Monorepo

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added inline comments. Comment at: clang/include/clang/Driver/Options.td:1193-1195 +defm caret_diagnostics : BoolFOption<"caret-diagnostics", + "DiagnosticOpts->ShowCarets", DefaultsToTrue, + ChangedBy, ResetBy>, IsDiag; dexonsmith wrote: > There

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 315131. jansvoboda11 added a comment. Don't create diagnostics_fixit_info via BoolXxxOption to keep the distinstion of Group and Group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 315117. jansvoboda11 added a comment. Move the "DiagnosticOpts->" prefix from TableGen definitions to macros Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 315115. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files: clang/include/clang/Basic/DiagnosticOptions.h

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith added inline comments. Comment at: clang/include/clang/Driver/Options.td:1193-1195 +defm caret_diagnostics : BoolFOption<"caret-diagnostics", + "DiagnosticOpts->ShowCarets", DefaultsToTrue, + ChangedBy, ResetBy>, IsDiag; There was one thing in the

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314907. jansvoboda11 added a comment. Use arrow instead of dot in keypath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314900. jansvoboda11 added a comment. Introduce `IsDiag` mixin, add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 314887. jansvoboda11 added a comment. Rebase on top of prep patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

dexonsmith added inline comments. Comment at: llvm/utils/TableGen/OptParserEmitter.cpp:102-107 + std::string getMacroName() const { +if (KeyPath.startswith("DiagnosticOpts.")) + return (Twine("DIAG_") + MarshallingInfo::MacroName).str(); + +return

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 313347. jansvoboda11 added a comment. Remove unnecessary if braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84673/new/ https://reviews.llvm.org/D84673 Files:

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 added a comment. I still need to figure out why Clang built in release mode replaces spaces in an error message by newlines and indents: $ ./build.noindex/debug/bin/clang -c clang/test/Driver/fmessage-length.c -fmessage-length=nan clang-12: error: invalid

[PATCH] D84673: [clang][cli] Port DiagnosticOpts to new option parsing system

jansvoboda11 updated this revision to Diff 313337. jansvoboda11 added a comment. Rebase, undo NFC changes. Replace the previous diagnostic option tagging system implemented in TableGen with less intrusive backend check. Extract prep patches. Repository: rG LLVM Github Monorepo CHANGES SINCE