[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8055 for (const auto L : C->component_lists()) { -InfoGen(std::get<0>(L), std::get<1>(L), OMPC_MAP_to, llvm::None, +SmallVector MapModifiers; +translateMotionModifiers(C

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8055 for (const auto L : C->component_lists()) { -InfoGen(std::get<0>(L), std::get<1>(L), OMPC_MAP_to, llvm::None, +SmallVector MapModifiers; +translateMotionModifiers(C

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c3faae49704: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2) (authored by jdenny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/ https://reviews.llvm.org/D84711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/ https://reviews.llvm.org/D84711 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:73-74 .Default(OMPC_MOTION_MODIFIER_unknown); +if (OpenMPVersion < 51 && Type != OMPC_MOTION_MODIFIER_mapper) + return OMPC_MOTION_MODIFIER_unknown; +return Type; ABat

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny updated this revision to Diff 281339. jdenny marked 4 inline comments as done. jdenny added a comment. Adjusted logic for rejecting `present` as requested. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84711/new/ https://reviews.llvm.org/D84711 Files: clang/include/c

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3462 + // OpenMP 5.1 accepts an optional ',' even if the next character is ':'. + // TODO: Is that intentional? + if (Tok.is(tok::comma)) jdenny wrote: > ABataev wrote: > >

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3462 + // OpenMP 5.1 accepts an optional ',' even if the next character is ':'. + // TODO: Is that intentional? + if (Tok.is(tok::comma)) ABataev wrote: > `FIXME`. This is a

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Basic/OpenMPKinds.cpp:73-74 .Default(OMPC_MOTION_MODIFIER_unknown); +if (OpenMPVersion < 51 && Type != OMPC_MOTION_MODIFIER_mapper) + return OMPC_MOTION_MODIFIER_unknown; +return Type; Bet

[PATCH] D84711: [OpenMP] Implement TR8 `present` motion modifier in Clang (1/2)

jdenny created this revision. jdenny added reviewers: ABataev, grokos, jdoerfert, RaviNarayanaswamy. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. This patch implements Clang front end support for the OpenMP TR8 `present` motion modifier for `om